[DNM] Run CI on some experimental peek optimizations #33946
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y on waiting_on_startup_appends
I think this superfluous error variant existed because earlier acquire_read_holds's parameters used to specify the time, but then the interface was changed to just acquire the earliest possible read hold, and we forgot to drop this error variant.
…to the storage controller in order to be able to use this instead of ReadHoldError in the next commit.
and make use of the fact that acquire_read_holds now returns a common error.
…rn a more specific error and make use of this in acquire_read_holds_and_least_valid_write
…eturn a more specific error and make use of this in acquire_read_holds_and_least_valid_write
…sions / waiting_on_startup_appends
We had a bunch of places with a `&mut Catalog` or an `Arc<Catalog>` where a simple `&Catalog` is enough. `&Catalog` is better performance-wise than `&mut Catalog`, because creating the latter (with calling `catalog_mut`) clones the whole catalog if there are any other Arcs to it. Similarly, `&Catalog` is also better than an `Arc<Catalog>`, because the latter's existence can cause other `catalog_mut` calls to make a clone.
so that the next commit needs to work only with SessionClient's catalog_snapshot, and not with PeekClient's catalog_snapshot (which is deleted in this commit).
ggevay
force-pushed
the
peek-frontend-catalog-snapshot-elimination
branch
from
f4346b4 to
044d037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for running Nightly's scalability benchmark on some experimental optimizations, which could be follow-ups to #33713. CI's machines might be more powerful than my laptop at high parallelism, and I'd like to test the scalability of peek sequencing.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.