Skip to content

Conversation

@def-
Copy link
Contributor

@def- def- commented Oct 28, 2025

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Copy link
Contributor

@jubrad jubrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably provide a community license key to buildkite

@def-
Copy link
Contributor Author

def- commented Oct 29, 2025

We have one (well, the developer key, not community), I'll put it in. Ideally we should have this documented too.

@def- def- force-pushed the pr-orchestratord-defaults branch from 96adb91 to d024e38 Compare October 29, 2025 07:25
@def- def- marked this pull request as ready for review October 29, 2025 07:28
@def- def- requested a review from a team as a code owner October 29, 2025 07:28
@def- def- requested a review from jubrad October 29, 2025 07:28
"MZ_CI_LICENSE_KEY"
]
else:
# TODO: Remove this part once environmentId is set in older versions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just set this in our provided sample yaml file to make life easier for customers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be unique per customer, though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should at least document a simple way to set it, ideally with a script that generates a uuid for them and puts it in automatically.

Copy link
Contributor

@alex-hunt-materialize alex-hunt-materialize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but I'm not sure we should set the environmentId in the sameple, as most customers will end up sharing that environmentId or hitting issues when the environmentId doesn't match their license.

@def- def- force-pushed the pr-orchestratord-defaults branch 3 times, most recently from c49d2ca to 12a1951 Compare October 29, 2025 10:13
@def- def- force-pushed the pr-orchestratord-defaults branch from 12a1951 to 38860c0 Compare October 29, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants