-
Couldn't load subscription status.
- Fork 482
orchestratord: Test defaults from our documentation #33967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably provide a community license key to buildkite
|
We have one (well, the developer key, not community), I'll put it in. Ideally we should have this documented too. |
96adb91 to
d024e38
Compare
| "MZ_CI_LICENSE_KEY" | ||
| ] | ||
| else: | ||
| # TODO: Remove this part once environmentId is set in older versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just set this in our provided sample yaml file to make life easier for customers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be unique per customer, though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we should at least document a simple way to set it, ideally with a script that generates a uuid for them and puts it in automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I'm not sure we should set the environmentId in the sameple, as most customers will end up sharing that environmentId or hitting issues when the environmentId doesn't match their license.
c49d2ca to
12a1951
Compare
12a1951 to
38860c0
Compare
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.