Skip to content

Conversation

@SangJunBak
Copy link
Contributor

  • Removes "kind" references since instructions are generic to the Materialize CR
  • Adds references to the Materialize CR fields
  • Adds how to actually deploy authentication with notice about accidentally overriding values.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

- Removes "kind" references since instructions are generic to the Materialize CR
- Adds references to the Materialize CR fields
- Adds how to actually deploy authentication with notice about accidentally overriding values.
@SangJunBak SangJunBak requested a review from a team as a code owner November 18, 2025 17:58
@SangJunBak SangJunBak requested a review from kay-kim November 18, 2025 17:58
Password authentication requires users to log in with a password.

To configure Self-Managed Materialize for password authentication:
To configure Self-Managed Materialize for password authentication, update the following fields in the [Materialize CR](/installation/appendix-materialize-crd-field-descriptions/):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ... let's remove the link here ... because that page just gives all the fields ... and we're giving the specific fields here.

We could go "For all Materialize CR settings, see ... "

compatible with PostgreSQL clients that support SCRAM-SHA-256.

To configure Self-Managed Materialize for SASL/SCRAM authentication:
To configure Self-Managed Materialize for SASL/SCRAM authentication, update the following fields in the [Materialize CR](/installation/appendix-materialize-crd-field-descriptions/):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

For more information on rollout configuration, view our [installation overview](/installation/#rollout-configuration).
{{< warning >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we repeat this warning in both places above where we talk about setting authenticatorKind?

It's important enough that I think repeating in throughout (as people hop onto just their interested section)

- Colocate warning about the `authenticatorKind` with authenticatorKind section
- Just reference link to Materialize CR rather than point to it.
@SangJunBak SangJunBak requested a review from kay-kim November 19, 2025 17:49
Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my side, LGTM. But left comment for Justin and Sid.

requestRollout: <SOME_NEW_UUID> # Generate new UUID for rollout
forceRollout: <SOME_NEW_UUID> # Rollout without requiring a version change
# Tears down the prior version and restarts the current Materialize instance
rolloutStrategy: ImmediatelyPromoteCausingDowntime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jubrad and @sidsaw-mz ... any concerns about using the ImmediatelyPromoteCausingDowntime strategy here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants