Add Claude GitHub actions #34403
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,57 @@ | ||||||
| name: Claude Code Review | ||||||
|
|
||||||
| on: | ||||||
| issue_comment: | ||||||
| types: [created] | ||||||
| pull_request_review_comment: | ||||||
| types: [created] | ||||||
|
|
||||||
| jobs: | ||||||
| claude-review: | ||||||
| if: | | ||||||
| ( | ||||||
| github.event_name == 'issue_comment' && | ||||||
| github.event.issue.pull_request && | ||||||
| contains(github.event.comment.body, '@claude review') && | ||||||
| contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) | ||||||
| ) || ( | ||||||
| github.event_name == 'pull_request_review_comment' && | ||||||
| contains(github.event.comment.body, '@claude review') && | ||||||
| contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) | ||||||
| ) | ||||||
| runs-on: ubuntu-latest | ||||||
| permissions: | ||||||
| contents: read | ||||||
| pull-requests: read | ||||||
| issues: read | ||||||
|
|
||||||
|
|
||||||
| steps: | ||||||
| - name: Checkout repository | ||||||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||||||
|
Contributor
There was a problem hiding this comment. Pretty old, but doesn't matter I guess. |
||||||
| with: | ||||||
| fetch-depth: 1 | ||||||
|
|
||||||
| - name: Run Claude Code Review | ||||||
| id: claude-review | ||||||
| uses: anthropics/claude-code-action@3a38b377b30c75102b420405ed9516b57ca2e248 # v1 | ||||||
|
Contributor
There was a problem hiding this comment. I can't even find this commit in their repo: anthropics/claude-code-action@3a38b37 So I think this won't work. |
||||||
| with: | ||||||
| claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} | ||||||
| prompt: | | ||||||
| REPO: ${{ github.repository }} | ||||||
| PR NUMBER: ${{ github.event.pull_request.number }} | ||||||
|
|
||||||
| Please review this pull request and provide feedback on: | ||||||
| - Code quality and best practices | ||||||
| - Potential bugs or issues | ||||||
| - Performance considerations | ||||||
| - Security concerns | ||||||
| - Test coverage | ||||||
|
Contributor
There was a problem hiding this comment. Can we make this something more targeted?
Suggested change
I'm still worried that Claude probably has no idea about what testing frameworks we have and whether they are used for the correct kind of testing. |
||||||
|
|
||||||
| Use the repository's CLAUDE.md for guidance on style and conventions. Be constructive and helpful in your feedback. | ||||||
|
Contributor
There was a problem hiding this comment. This file doesn't exist, did you mean doc/developer/{best-practices.md,guide-changes.md}? |
||||||
|
|
||||||
| Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR. | ||||||
|
Contributor
There was a problem hiding this comment. I bet you can make Claude comment something on another person's PR from what you write in the body of your own PR. ;) |
||||||
|
|
||||||
| # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md | ||||||
| # or https://code.claude.com/docs/en/cli-reference for available options | ||||||
| claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"' | ||||||
|
|
||||||
|
|
||||||
|
Contributor
There was a problem hiding this comment. claude-code-review.yml is for code reviews. What is this file for? I don't see that Claude has any permissions to do something here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| name: Claude Code | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
|
|
||
| jobs: | ||
| claude: | ||
| if: | | ||
| ( | ||
| github.event_name == 'issue_comment' && | ||
| contains(github.event.comment.body, '@claude') && | ||
| contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) | ||
| ) || ( | ||
| github.event_name == 'pull_request_review_comment' && | ||
| contains(github.event.comment.body, '@claude') && | ||
| contains('OWNER,MEMBER,COLLABORATOR', github.event.comment.author_association) | ||
| ) | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: read | ||
| actions: read # Required for Claude to read CI results on PRs | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| fetch-depth: 1 | ||
|
|
||
| - name: Run Claude Code | ||
| id: claude | ||
| uses: anthropics/claude-code-action@3a38b377b30c75102b420405ed9516b57ca2e248 # v1 | ||
| with: | ||
| claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} | ||
|
|
||
| # This is an optional setting that allows Claude to read CI results on PRs | ||
| additional_permissions: | | ||
| actions: read | ||
|
|
||
| # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it. | ||
| # prompt: 'Update the pull request description to include a summary of changes.' | ||
|
|
||
| # Optional: Add claude_args to customize behavior and configuration | ||
| # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md | ||
| # or https://code.claude.com/docs/en/cli-reference for available options | ||
| # claude_args: '--allowed-tools Bash(gh pr:*)' | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? In your description you said: