mz-deploy: enforce database GRANT target in database mod files (DEX-45) - #37373
Open
sjwiesman wants to merge 1 commit into
Open
mz-deploy: enforce database GRANT target in database mod files (DEX-45)#37373sjwiesman wants to merge 1 commit into
sjwiesman wants to merge 1 commit into
Conversation
The target-database check in a database mod file only inspected `UnresolvedObjectName::Item` targets, but `GRANT ... ON DATABASE x` parses the target as `UnresolvedObjectName::Database`. The loop therefore never ran for a database grant, so a grant on a different database validated cleanly. Match the `Database` target and compare its raw name against the file's database. Ticket: DEX-45 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sjwiesman
marked this pull request as ready for review
July 1, 2026 14:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target-database check in a database mod file only inspected
UnresolvedObjectName::Itemtargets, butGRANT ... ON DATABASE xparses the target as
UnresolvedObjectName::Database. The loop thereforenever ran for a database grant, so a grant on a different database
validated cleanly. Match the
Databasetarget and compare its raw nameagainst the file's database.
Ticket: DEX-45
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
🤖 Generated with Claude Code
https://claude.ai/code/session_01VAcnVpSQi8ZgF5LekQRwvw