persist: remove unused MINIMUM_CONSOLIDATED_VERSION - #37489
Open
ggevay wants to merge 1 commit into
Open
Conversation
MINIMUM_CONSOLIDATED_VERSION gated assumptions about codec-order consolidation: parts written before it could not be assumed to be consolidated or sorted according to the current definition. Its last consumers were removed in f02f202 ("Remove codec-order consolidation") when consolidation moved entirely to structured (Arrow) ordering with per-run RunOrder metadata, leaving the constant unreferenced. Also update the comment on the SourceData serialization stability test, which still instructed encoding changes to bump the constant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MINIMUM_CONSOLIDATED_VERSIONgated assumptions about codec-order consolidation: parts written before it could not be assumed to be consolidated/sorted according to the current definition. Its last consumers were removed in f02f202 ("Remove codec-order consolidation") when consolidation moved entirely to structured (Arrow) ordering with per-runRunOrdermetadata, leaving the constant unreferenced.Removing it avoids sending future readers down a dead path: the comment on the
source_proto_serialization_stabilitytest inmz-storage-typesstill instructed encoding changes to "increase the MINIMUM_CONSOLIDATED_VERSION as part of the same release", an instruction that has had no effect since then. This PR updates that comment as well. (#37482 corrects the same comment in more detail and will be rebased on top of this PR.)🤖 Generated with Claude Code
(#37482 is on top of this PR.)