compute: Emit FlatMap output as the columnar edge - #37768
Draft
antiguru wants to merge 1 commit into
Draft
Conversation
antiguru
force-pushed
the
columnar-p4-flatmap-output
branch
from
July 22, 2026 08:41
dad8672 to
c14d129
Compare
antiguru
force-pushed
the
columnar-p4-flatmap-output
branch
from
July 22, 2026 16:24
c14d129 to
baad56b
Compare
antiguru
force-pushed
the
columnar-p4-flatmap-output
branch
from
July 22, 2026 17:50
baad56b to
fa39476
Compare
antiguru
force-pushed
the
columnar-p4-flatmap-output
branch
from
August 19, 2026 12:01
fa39476 to
242f5c0
Compare
antiguru
force-pushed
the
columnar-p4-flatmap-output
branch
2 times, most recently
from
August 20, 2026 08:49
4113b07 to
57e594c
Compare
antiguru
force-pushed
the
columnar-p4-flatmap-output
branch
from
August 20, 2026 09:13
57e594c to
94d99b4
Compare
Flip FlatMap's output to build into a `ConsolidatingColumnBuilder`, returning a `CollectionEdge::Columnar`. The pre-migration ok builder was already a consolidating one, so within-batch folding is preserved. Output rows are freshly built by the mfp, so the owned give into staging is a move, not a new alloc. The err collection stays `Vec`. The input side and fuel machinery are unchanged. Adds a within-batch duplicate-fold test and updates the arms-agree and fuel tests to decode the columnar capture. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
antiguru
force-pushed
the
columnar-p4-flatmap-output
branch
from
September 6, 2026 18:23
94d99b4 to
f81c1a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlatMap emits its output as the columnar edge.
Columnar dataflow-edge migration. Design doc:
doc/developer/design/20260720_columnar_dataflow_edges.md(#37744).Part of CPU-51.