compute: Retire the concat_many mixed-variant branch - #37796
Draft
antiguru wants to merge 3 commits into
Draft
Conversation
antiguru
force-pushed
the
columnar-td-concat-many
branch
from
July 22, 2026 08:41
310ba0c to
f459648
Compare
antiguru
force-pushed
the
columnar-td-concat-many
branch
from
July 22, 2026 16:24
f459648 to
7c88c83
Compare
antiguru
force-pushed
the
columnar-td-concat-many
branch
from
July 22, 2026 17:50
7c88c83 to
e610449
Compare
antiguru
force-pushed
the
columnar-td-concat-many
branch
2 times, most recently
from
August 19, 2026 13:17
1f40997 to
fc429ab
Compare
antiguru
force-pushed
the
columnar-td-concat-many
branch
from
August 20, 2026 08:49
fc429ab to
1bc6cfb
Compare
antiguru
force-pushed
the
columnar-td-concat-many
branch
from
August 20, 2026 09:13
1bc6cfb to
a631a06
Compare
Every producer now emits the columnar edge, so `concat_many` can never receive a `Vec` input. Remove the mixed-variant upgrade branch (the `vec_to_columnar` upgrade) and the now-unreachable all-`Vec` branch, leaving only the native all-columnar concatenation. The enum still carries a `Vec` arm until the collapse, so the input match type-handles `CollectionEdge::Vec` with an `unreachable!`. Removing the last branch that constructed a `Vec` edge leaves the variant unconstructed, so it carries `#[allow(dead_code)]`; the arm, the attribute, and the `unreachable!` are removed together when the enum collapses to a columnar alias. `vec_to_columnar` stays, still used by the leaf-encodes (imports, join no-closure, temporal bucketing, LetRec). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The concat_many teardown made the Vec arm unreachable, so a mixed Vec/Columnar input can no longer reach concat_many. Feed two columnar edges instead, which is the only shape producers now emit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Comment-only, no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
antiguru
force-pushed
the
columnar-td-concat-many
branch
from
September 6, 2026 18:23
a631a06 to
7d5cf9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retire the
concat_manymixed-variant upgrade branch now that no producer emits a Vec edge (the temporal-bucketing and LetRec re-encodes removed the last two sources). Rewrites the unit test to exercise all-columnar concatenation.Columnar dataflow-edge migration. Design doc:
doc/developer/design/20260720_columnar_dataflow_edges.md(#37744).Part of CPU-51.