SAS-172: Surface structured backend error messages instead of a generic fallback - #37902
Draft
rjimeno-mz wants to merge 1 commit into
Draft
Conversation
… a generic fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiErrortype (cloud#13055).openapi-fetchsplits a response intodata(2xx) orerror(non-2xx), never both, buthandleOpenApiResponse/handleOpenApiResponseWithBodyonly ever readdata. A JSON error body could never reach the client regardless of backend changes.erroris now an optional third parameter (backward compatible with all other call sites), wired through forgetCostsBreakdownDaily.getApiError()(src/api/openApiUtils.ts) to extract the structured body from a caught error.AccountSpendBreakdownnow shows the backend's real message, and a request id (for non-validation reasons) instead of always showing a hardcoded generic string.Test plan
yarn typecheck/yarn lintbilling/apisuites pass (166 tests)Resolves SAS-172 (merges SAS-149 and SAS-164). Follow-up for the remaining endpoints/call sites: SAS-174.