sql-150: reclaim storage metadata for ephemeral items on crash - #38160
Merged
Conversation
SangJunBak
changed the title
def-
previously requested changes
Aug 12, 2026
Comment on lines
+1483
to
+1484
| # The comment row dies with its item. | ||
| comments = c.sql_query(temp_comment_count, port=6877, user="mz_system") |
Contributor
There was a problem hiding this comment.
This should actually check something
Suggested change
| # The comment row dies with its item. | |
| comments = c.sql_query(temp_comment_count, port=6877, user="mz_system") | |
| # The comment row dies with its item. | |
| comments = c.sql_query(temp_comment_count, port=6877, user="mz_system") | |
| assert comments == [ | |
| (0,) | |
| ], f"the temp table's comment survived the restart: {comments}" |
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
3 times, most recently
from
August 13, 2026 01:35
5efd494 to
3b9c0fb
Compare
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
from
August 13, 2026 15:19
3b9c0fb to
1537f61
Compare
mtabebe
approved these changes
Aug 13, 2026
mtabebe
left a comment
mtabebe
left a comment
Contributor
There was a problem hiding this comment.
Thanks, change looks good. Great work
| /// Used to reclaim temporary items when the catalog is opened with write | ||
| /// intent, at which point every session that could own one is dead. | ||
| /// | ||
| /// This must mirror everything the graceful `Op::DropObjects` path |
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
from
August 14, 2026 16:07
1537f61 to
5b6e289
Compare
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
from
August 14, 2026 16:54
5b6e289 to
3636dec
Compare
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
2 times, most recently
from
August 17, 2026 19:35
72e7799 to
bcfb786
Compare
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
from
August 19, 2026 19:00
bcfb786 to
17bf6eb
Compare
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
from
August 19, 2026 20:34
17bf6eb to
d8ea46b
Compare
…t (SQL-150) When a process crash-restarted, shards from temp tables were never cleaned up. However, on graceful close, we do clean up these shards. This was an existing bug from before the durable temporary objects change.
SangJunBak
force-pushed
the
jun/move-temp-to-catalog-split-4
branch
from
August 20, 2026 14:46
d8ea46b to
3dc0e17
Compare
SangJunBak
dismissed
def-’s stale review
August 20, 2026 18:58
Addressed his changes and he's now on parental leave
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sql-150
Description
catalog: reclaim storage metadata for ephemeral items on crash restart (SQL-150)
When a process crash-restarted, shards from temp tables were never cleaned up. However, on graceful close, we do clean up these shards. This was an existing bug from before the durable temporary objects change.
Verification
Extended the temp object cleanup test to check for shard finalization