dbt-materialize: quote the schema when copying default privileges - #38191
Merged
def- merged 1 commit intoAug 13, 2026
Merged
Conversation
`internal_copy_schema_default_privs` interpolated the target schema name raw into `ALTER DEFAULT PRIVILEGES ... IN SCHEMA`, so the parser folded it to lowercase. MaterializeInc#38066 started creating the deployment schema with a quoted name, which made the two disagree for any schema name that is not a bare lowercase identifier: `deploy_init` created `"Prod_dbt_deploy"` and then failed trying to alter default privileges in `prod_dbt_deploy`, after the schema already existed. The retry then took the schema-already-exists branch, which skips both privilege-copying macros, so the operation reported success while silently dropping the grants and default privileges the production schema had. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jubrad
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal_copy_schema_default_privsinterpolated the target schema name raw intoALTER DEFAULT PRIVILEGES ... IN SCHEMA, so the parser folded it to lowercase. #38066 started creating the deployment schema with a quoted name, which made the two disagree for any schema name that is not a bare lowercase identifier:deploy_initcreated"Prod_dbt_deploy"and then failed trying to alter default privileges inprod_dbt_deploy, after the schema already existed. The retry then took the schema-already-exists branch, which skips both privilege-copying macros, so the operation reported success while silently dropping the grants and default privileges the production schema had.Test run: https://buildkite.com/materialize/nightly/builds/18074