compute: log unhydrated collections in one line per check - #38251
Merged
Merged
Conversation
`collections_hydrated_on_replicas` logged one INFO line per non-hydrated collection, and the cluster controller polls it on a tick tests turn down to 5ms. That made it the single largest contributor to CI log volume: 220,971 lines in one `test` build, 12% of all `services.log` lines, peaking at 13,076 per second. Name them all in one line instead. The diagnostic keeps its full content and the line count drops by the size of the unhydrated set. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
antiguru
approved these changes
Aug 17, 2026
antiguru
left a comment
antiguru
left a comment
Member
There was a problem hiding this comment.
Thank you, this has been bothering me for so long!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collections_hydrated_on_replicaslogged one INFO line per non-hydrated collection, and the cluster controller polls it on a tick tests turn down to 5ms. That made it the single largest contributor to CI log volume: 220,971 lines in onetestbuild, 12% of allservices.loglines, peaking at 13,076 per second.Name them all in one line instead. The diagnostic keeps its full content and the line count drops by the size of the unhydrated set.