Make sure scenario version applies for source ingestion - #38377
Merged
peterdukelarsen merged 1 commit intoAug 20, 2026
Conversation
run_scenario read VERSION off the sweep wrapper, but the wrappers never exposed the wrapped workload's VERSION, so a bump on a workload class (e.g. SourceIngestionScenario 1.1.0) fell through to the driver Scenario's default "1.0.0" and never reached the recorded results. Replace the driver Scenario's VERSION attribute with a version() method that sweeps override to delegate to their workload, while direct scenarios keep the documented default. Workloads keep VERSION as the attribute to bump. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
peterdukelarsen
force-pushed
the
version-forwarding-fix
branch
from
August 20, 2026 19:06
8b3d79d to
bc639e6
Compare
def-
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part of: SS-432
#38363 (comment)
I bumped the source ingestion scenario to indicate we couldn't compare against historical runs due to a bump in the mysql version. This didn't actually work because the scenario is wrapped with a
StrongScalingSweep(or one of a couple other classes), which inherits from the root Scenario the old version. So we want to make the individual source ingestion version bump take precedence over the StrongScalingSweep etc. versions.Description
Makes the version a method that different implementations can override. We have the wrapping scenarios delegate to the underlying workloads.
This will let us override other specific workloads independently, but we will either need to patch in some sort of version fudging or bump the other global version if we tweak
StrongScalingSweepin the future.Verification