Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some fields in replication messages public #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

semtexzv
Copy link

@semtexzv semtexzv commented Jan 4, 2023

It is impossible to move values from parsed messages, since everything is available only by a reference. This dumb PR just makes the complex fields public, so that the user does not have to clone all the data. Other implementations are welcome

It is impossible to move values from parsed messages, since everything is available only by a reference
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@semtexzv semtexzv changed the title Make some fields public Make some fields in replication messages public Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants