Add support for custom environmentd arguments

[bobbyiliev]

No description provided.

[jubrad]

Change looks good. G2G if you validated this one works through one of the other tf modules.

[bobbyiliev]

Change looks good. G2G if you validated this one works through one of the other tf modules.

I've just tested this with the AWS module, the env var is set:

kubectl describe pod  -n materialize-environment mzz9zuhf0269-environmentd-1-0
   ...
    Environment:
      MZ_METADATA_BACKEND_URL:      ...
      MZ_PERSIST_BLOB_URL:        ...
      AWS_REGION:                   us-east-1
      ENABLE_COLUMNATION_LGALLOC:   true
      AWS_STS_REGIONAL_ENDPOINTS:   regional
      AWS_ROLE_ARN:                 arn:aws:iam::....:role/bobby-test...
      AWS_WEB_IDENTITY_TOKEN_FILE:  /var/run/secrets/eks.amazonaws.com/serviceaccount/token

However:

mz_system=> SHOW enable_columnation_lgalloc;
 enable_columnation_lgalloc 
----------------------------
 off

[bobbyiliev]

Change looks good. G2G if you validated this one works through one of the other tf modules.

Just updated this PR to have the following format: MZ_SYSTEM_PARAMETER_DEFAULT=key=value;.. however this still does not get picked up correctly.

The env is passed along to the envd pod:

materialize@mz9hv0020kkf-environmentd-1-0:/$ printenv | grep MZ_ 
MZ_SYSTEM_PARAMETER_DEFAULT=enable_columnation_lgalloc=true

But the value is still not updated:

mz_system=> show enable_columnation_lgalloc;
 enable_columnation_lgalloc 
----------------------------
 off

Any suggestions?

[jubrad]

This is due to a conflict with other default values leveraging --system-parameter-default
We should

1. proceed with this PR (it's good as is)
2. also include environmentdExtraArg which can be specified like so

environmentdExtraArgs:
  - --system-parameter-default=allow_real_time_recency=true
  - --system-parameter-default= enable_connection_validation_syntax=true

This seems to work to:

1. provide env vars to environmentd (these won't subsequently get passed to clusterd which is a bit of a bummer)
2. allow us to set default system params directly from terraform