Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding benchmarks for git domain #719

Draft
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented May 14, 2024

Description

This PR adds benchmarks for the git domain. Mostly to have a good point of reference when making optimisation upgrades to the DB and EFS.

NOTE: this is targeting another feature branch while it is worked on. This is blocked by the git refactoring and requires that to be merged before switching the target branch to staging and merging.

Issues Fixed

Tasks

  • 1. Add appropriate benchmarks for git domain.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this May 14, 2024
Copy link

linear bot commented May 14, 2024

@tegefaulkes tegefaulkes changed the base branch from staging to feature-eng-68-review-and-refactor-of-gitutilsts-for-serving-vault-git May 14, 2024 07:34
@tegefaulkes tegefaulkes changed the base branch from feature-eng-68-review-and-refactor-of-gitutilsts-for-serving-vault-git to staging May 15, 2024 03:56
@tegefaulkes
Copy link
Contributor Author

Switched base over staging now that git refactoring has been merged.

@CMCDragonkai
Copy link
Member

I feel like the suites need to be named better.

@tegefaulkes
Copy link
Contributor Author

I think we can merge what we have so far and revisit the issue again later. This will need a quick review and I can work on merging it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adding benchmarks for git domain to polykey
2 participants