Skip to content

Lamar Migration #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 25, 2025
Merged

Conversation

nminaya
Copy link
Contributor

@nminaya nminaya commented Jan 21, 2025

  • Replace StructureMap with Lamar due to its deprecation.
  • Update projects .NET version

@MattHoneycutt
Copy link
Owner

@nminaya Sorry for the delay in getting feedback here. As I went to merge this in, I noticed a few things I'd like us to fix:

  • Instead of repurposing the existing SpecsFor.StructureMap project, let's add a new one for SpecsFor.Lamar, and leave the existing SpecsFor.StructureMap alone. You can see that we took a similar path on SpecsFor.Autofac.
  • Name the auto-mocker LamarAutoMocker rather than SpecsForAutoMocker.

I hope that makes sense, LMK if you have any questions or need help.

@nminaya
Copy link
Contributor Author

nminaya commented Mar 18, 2025

@MattHoneycutt I went with the suggested approach but realized that now the code in SpecsFor.Lamar library is not covered with unit tests. Should I just create a SpecsFor.Lamar.Tests similar to SpecsFor.StructureMap.Tests?

@matthoneycutt-sm
Copy link
Contributor

@nminaya Yeah, that's what we did for Autofac - there's a SpecsFor.Autofac.Tests project. That's probably something you could get Copilot Edits to generate, FYI.

@MattHoneycutt MattHoneycutt merged commit 1521e19 into MattHoneycutt:master Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants