[pull] develop from chocolatey:develop #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Some part of the existing code used in one of the projects used C# features that was only made available in version 7.1 of the language specifications, as there was only a limit on a single project that would deny this change all of the different projects in the solution have been updated to restrict the language syntax to use C# 7.1.
This commit creates a new converter with the responsibility to grab a resource string by it name and use that resource string to format the return value if the converter parameter is a string.
This commit updates the existing Views to ensure they are using the correct extension methods that is needed to allow changing Languages dynamically possible.
This commit updates the class module for Internationalization to look at installation location of Chocolatey GUI and only collect the languages that have been installed by the program.
This code updates the relevant parts of acquiring and keeping track of different settings values so it can be updated whenever the language is changed by the user.
This commit add/updates the code that initialises the current culture to ensure that the preferred language is being used at the application startup.
This commit updates the existing calls to `Resource.` static class to instead make calls to our own custom `TranslationSource` class to ensure that we are using the same logic for the translation strings everywhere in the code. Additionally, there was a few places in the code that would not use the correct language when calling the Resource class directly, switch to the translation source fixes those.
(#533) Ability to change language dynamically
This commit makes changes to how the Chocolatey API is being called, which then allows the original logging that Chocolatey implements to still happen when we add our own Serilog logger. This change depends on a new change in the Chocolatey codebase, and a new release of the program.
(#697) Update Chocolatey API calling
This commit replaces the values in sensitive arguments to instead show the translatable string `[REDACTED ARGUMENT]` to ensure that sensitive arguments are not displayed to the user. This relies on the ArgumentUtility helper to detect whether the sensitive argument should be shown or not.
This commit updates the dialog for showing package arguments to have a notice that no arguments was found for the package in the same dialog as normal arguments would show up with.
This commit updates the package view to hide the button for displaying package arguments when it is not displayed.
…persisted-arguments-for-installed-package (#770) Provide ability to see persisted arguments for installed package
This commit adds a new entry for the Cache Location when doing advanced installations. This new entry allows the user to browse to a directory to select the location where cached installers and archives ends up.
This comit updates the configuration description when doing advanced installation by removing the parts of the string that need to be formatted with the value that have the current configuration have as defaults. Additional, the mention of which Chocolatey versions that support the respective feature have been removed from the view.
This commit adds support for specifying a specific log file path, unfortunately as there are changes needed to be made in Chocolatey CLI we are unable to enable this support for users at the moment.
This commit updates the code necessary to make the version combobox editable while allowing the user to select the latest version, or the version they opened the Advanced Installation window on. Additionally, due to known issues with populating available versions for the user (both on CCR, Nexus and Artifactory) fetching of remote versions are disabled until further notice.
This commit updates the Dialog Service and the ShellView to make sure that a dialog being open is marked correctly. This is done to ensure that buttons for Settings and About views are not clickable when the Advanced Installation window is open.
This commit fixes an issue where if the remote sources view was selected before going into the settings view, when the language is then changed it would reload the packages that was already acquired which at some rare times could result in an endless loop. This fix changes that, to instead only reload the sources if the remote sources view is active, and as thus checks for the sources when the view gets activated the first time instead of during the initialization phase.
This comit adds missing code that should have been set WPF elements with the correct language code (and direction) when a language is initially set, or when the language gets changed. The right to left changes is not perfect, but until there is feedback from users that uses such a locale it is the best we can do at the moment.
This commit updates the Advanced Installation view to disable some features, and other arguments when they do not make sense to be able to be passed. As an example, when skip powershell is selected it do not make sense to being able to input package parameters, installation arguments, override arguments, pass in not silent or any of the checksum related arguments.
This commit removes any trailing space, and fixes the xmlns statements for the advanced installation view.
(build) Install dotnet-6.0-runtime for QA Build
(#967) Parse Info messages for errors
While not "required" for this repository, updating all usages of the Recipe package to the latest version, now that a build issue has been addressed with the Chocolatey GUI Licensed Extension build.
This includes a fix specifically for when building Web Application projects, which although doesn't apply to this repository, it makes sense to update to the latest version.
If the directory for a LiteDatabase doesn't exist, LiteDatabase will not attempt to create it, and will throw an exception because it can't create the file without the parent directory. This ensures that the folder exists before trying to create the database.
(#996) Create config directory if it doesn't exist
Also change gitHubTokenVariable to gitReleaseManagerTokenVariable to reflect change in chocolatey.cake.recipe.
…ager/.templates/'
(maint) synced file(s) with chocolatey/.github
The build is failing on the hotfix branch, when it isn't on the develop branch, and this is the only immediate difference between the two branches.
No new features in this release which are applicable to Chocolatey CLI, but still good to keep this package up to date when it changes.
* hotfix/2.1.1: (build) Switch to a PowerShell step (maint) synced local '.templates/' with remote '.github/GitReleaseManager/.templates/' (build) Bump Recipe package to latest version (maint) Remove unnecessary whitespace (#996) Create config directory if it doesn't exist (maint) Remove unused pragmas (#967) Parse Info for Error, Warn, and Fatal
* master: (build) Switch to a PowerShell step (maint) synced local '.templates/' with remote '.github/GitReleaseManager/.templates/' (build) Bump Recipe package to latest version (maint) Remove unnecessary whitespace (#996) Create config directory if it doesn't exist (maint) Remove unused pragmas (#967) Parse Info for Error, Warn, and Fatal (maint) Remove mention of services no longer used (tests) Update Pester tests to be consistent (tests) Move the Pester tests to be consistent (maint) synced local '.templates/' with remote '.github/GitReleaseManager/.templates/' (maint) Update GRM configuration
Based on changes to how the Authenticode signing works (namely the need to use a hardware HSM, or a software as a service based solution), we need to look to prevent unnecessary signing of files happening. Signing of files is not required on the scheduled Integration Testing and SonarQube builds, so we are removing it from these builds. This is done using the command line options for: --shouldAuthenticodeSignMsis=false --shouldAuthenticodeSignOutputAssemblies=false --shouldAuthenticodeSignPowerShellScripts=false
(build) (ENGTASKS-3694) Update Chocolatey.Cake.Recipe to latest
In the previous round of changes, we were a little too quick to remove the signing step from the main build configuration. This is needed, as well as calling build.official.bat, in order to get an official release. The other build configurations, except the signing scripts, one, don't need the signing keys in place, so this has also been done in this commit.
This commit takes the newly signed PowerShell scripts from the build server and adds them into the source code repository. A new process for re-signing the files will be followed to ensure that the signature remains in tact.
…hub/workflows/stale.yml'
(maint) synced file(s) with chocolatey/.github
This is an attempt to ensure that any changes to our dependencies, whether that is: * changes to NuGet packages through packages.config files Are tracked and updated properly. By making these files/folder owned by the new @chocolatey-credits-reviewers group, it means that a member of that group will be flagged on any PR's that we raised that contain these files.
This extension is useful when editing Markdown files, especially when it contains a Table Of Contents. This extension will update the TOC simply by making changes to the main body.
(maint) Add recommended extension
v2 of the upload-artifact action is now deprecated, and the recommendation is to move to using v4: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
(build) Add templated notifications to all build configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )