Fix -Wundef warnings for MBEDTLS_GCC_VERSION in alignment.h#10717
Open
lhuang04 wants to merge 1 commit into
Open
Fix -Wundef warnings for MBEDTLS_GCC_VERSION in alignment.h#10717lhuang04 wants to merge 1 commit into
lhuang04 wants to merge 1 commit into
Conversation
MBEDTLS_GCC_VERSION is only defined when the compiler is GCC (not clang or other compilers). Lines 284 and 287 used it in bare #if directives without a defined() guard, triggering -Wundef warnings. Add defined(MBEDTLS_COMPILER_IS_GCC) guard to both lines. Signed-off-by: Lin Huang <lhuang04@meta.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MBEDTLS_GCC_VERSIONis only defined for GCC inbuild_info.h(excluded for clang via!defined(__clang__)). Lines 284 and 287 ofalignment.hused it in bare#ifdirectives without adefined()guard. When compiling with clang and-Wundef, the undefined macro triggers warnings through the include chaincommon.h→build_info.h→alignment.h.Add
defined(MBEDTLS_COMPILER_IS_GCC)guard to both lines.Reproduce
Testing
Build and SSL test suites pass.
A corresponding fix for the development branch has been submitted as Mbed-TLS/TF-PSA-Crypto#(add PR number).
PR checklist