Update the curves domain to use PSA macros in depends.py
#9633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-mezei-arm
added
enhancement
needs-ci
5 tasks
gabor-mezei-arm
force-pushed
the
9143_update_depends.py_curves_domain
branch
from
78e7e8d to
33b3f53
Compare
gabor-mezei-arm
removed
the
needs-preceding-pr
gabor-mezei-arm
force-pushed
the
9143_update_depends.py_curves_domain
branch
from
33b3f53 to
a8bfee0
Compare
ronald-cron-arm
requested changes
Jan 8, 2025
gabor-mezei-arm
force-pushed
the
9143_update_depends.py_curves_domain
branch
from
a8bfee0 to
44bce72
Compare
gabor-mezei-arm
force-pushed
the
9143_update_depends.py_curves_domain
branch
from
44bce72 to
64a264f
Compare
ronald-cron-arm
requested changes
Jan 14, 2025
ronald-cron-arm
previously approved these changes
Jan 27, 2025
There was a problem hiding this comment.
LGTM, thanks. @minosgalanakis please have another look, thanks.
Exclude the SECP224K1 curve due it is unstable via the PSA API. Signed-off-by: Gabor Mezei <[email protected]>
Instead of using the `crypto_knowledge.py`, use basic symbol matching for the `PSA_WANT_ECC_*` macros to search for in the `curves` domain of `depend.py`. Signed-off-by: Gabor Mezei <[email protected]>
The `PSA_WANT_ALG_SECP_K1_224` symbol has been removed. Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
gabor-mezei-arm
force-pushed
the
9143_update_depends.py_curves_domain
branch
from
08f723e to
7554eea
Compare
|
Rebased due to CI issues |
minosgalanakis
added
the
approved
Merged
via the queue into
Mbed-TLS:development
with commit Jan 29, 2025
d883ba7
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
depends.pyuse PSA macros for thecurvesdomain.Resolve #9143
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.