Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Remove deprecated function mbedtls_ssl_conf_curves() #9906

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

[dev] Remove deprecated function mbedtls_ssl_conf_curves() #9906

wants to merge 6 commits into from
+15 −232

Conversation

mpg
Copy link
Contributor

@mpg mpg commented Jan 14, 2025 •
edited by gilles-peskine-arm
Loading

Description

Resolve #9891

PR checklist

  • changelog provided
  • development PR provided HERE
  • framework PR not required
  • 3.6 PR provided [3.6 backport]: mbedtls_conf_curves() #9907
  • 2.28 PR not required because: 2.28 not affected
  • tests not required because: covered by existing tests

mpg added 5 commits January 14, 2025 12:06
@mpg
Remove deprecated function mbedtls_ssl_conf_curves()
93d4591 
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@mpg
Remove mbedtls_ssl_conf::curve_list
6b72016 
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@mpg
Remove internal helper mbedtls_ssl_get_groups()
6402c35 
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@mpg
Remove useless dependency from test function
4c3134a 
This dependency was never right in the first place.

Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@mpg
Add ChangeLog entry
4787b40 
Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@mpg mpg added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 14, 2025
@mpg mpg self-assigned this Jan 14, 2025
@mpg mpg mentioned this pull request Jan 14, 2025
Open
5 tasks
@mpg mpg added needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 15, 2025
@mpg
Copy link
Contributor Author

mpg commented Jan 15, 2025

Note: the API-ABI check is quite correct in pointing out that the removal of mbedtls_ssl_conf_curves() is an API break and that of mbedtls_ssl_config::curves_list an ABI break, but that's to be expected, and the reason why this is 4.0 only.

@mpg mpg added the api-break This issue/PR breaks the API and must wait for a new major version label Jan 15, 2025
@mpg
Fix incorrect test function
c4e768a 
We should not manually set the TLS version, the tests are supposed to
pass in 1.3-only builds as well. Instead do the normal thing of setting
defaults. This doesn't interfere with the rest of the testing, so I'm
not sure why we were not doing it.

Signed-off-by: Manuel Pégourié-Gonnard <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Jan 22, 2025
gilles-peskine-arm
gilles-peskine-arm requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I don't like leaving a bit of obsolete documentation in the 3.0 migration guide. I think we should either update it or remove it (I'd be ok with a plan to remove it in a separate PR).

ChangeLog.d/rm-ssl-conf-curves.txt
@@ -0,0 +1,4 @@
Removals
* Remove the function mbedtls_ssl_conf_curves() which had been deprecated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update 3.0-migration-guide.md here as well. Unless we just remove it at this point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mpg mpg

Labels
api-break This issue/PR breaks the API and must wait for a new major version needs-reviewer This PR needs someone to pick it up for review needs-work priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated function mbedtls_ssl_conf_curves()
2 participants
@mpg @gilles-peskine-arm