Remove the DHE-RSA key exchange #9917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
valeriosetti
added
needs-review
valeriosetti
force-pushed
the
issue9685
branch
from
dd86bb8 to
91ae591
Compare
valeriosetti
removed
the
needs-preceding-pr
valeriosetti
force-pushed
the
issue9685
branch
from
91ae591 to
7a94a1b
Compare
|
Rebased to solve a conflict in |
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
In this commit also MBEDTLS_KEY_EXCHANGE_SOME_DHE_ENABLED is removed. This cause some code in "ssl_ciphersuites_internal.h" and "ssl_tls12_server.c" to became useless, so these blocks are removed as well. Signed-off-by: Valerio Setti <[email protected]>
This symbol is unused in the code so it can be removed. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
…NABLED Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue9685
branch
from
ad6b4fa to
ac9d5d9
Compare
valeriosetti
force-pushed
the
issue9685
branch
from
3cba7a1 to
c303ffc
Compare
Hanshake serialization requires that the selected ciphersuite uses an AEAD algorithm. However, following the DHE-RSA removal, trying to still use RSA signature might select a ciphersuite which is not using AEAD, but CBC instead. Also ECDSA has ciphersuites with CBC, but they have lower priority compared to AEAD ones, so they are less likely to be picked. Signed-off-by: Valerio Setti <[email protected]>
Signed-off-by: Valerio Setti <[email protected]>
valeriosetti
force-pushed
the
issue9685
branch
from
c303ffc to
86d5913
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9685
Depends on:
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.