Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add X.509 formatting validation to SECURITY.md #9918

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add X.509 formatting validation to SECURITY.md #9918

merged 3 commits into from
Jan 23, 2025
+19 −0

Conversation

davidhorstmann-arm
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm commented Jan 22, 2025 •
edited
Loading

Clarify that strict formatting of X.509 certificates is not checked by Mbed TLS and that it therefore should not be used to construct a CA.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Sorry, something went wrong.

@davidhorstmann-arm
Add X.509 formatting validation to SECURITY.md
2fe0da7 
Clarify that strict formatting of X.509 certificates is not checked by
Mbed TLS and that it therefore should not be used to construct a CA.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
This was referenced Jan 22, 2025
Merged
Merged
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review labels Jan 22, 2025
@davidhorstmann-arm
Add paragraph on undefined behaviour
faa1a0f 
Add a note that we do aim to protect against undefined behaviour and
undefined behaviour in certificate parsing is in scope.

Signed-off-by: David Horstmann <david.horstmann@arm.com>
@gilles-peskine-arm gilles-peskine-arm self-requested a review January 22, 2025 17:29
tom-cosgrove-arm
tom-cosgrove-arm reviewed Jan 23, 2025
View reviewed changes
@davidhorstmann-arm
Fix missing-word typo
0704fbf 
Signed-off-by: David Horstmann <david.horstmann@arm.com>
mpg
mpg approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 23, 2025
@yanesca yanesca added this pull request to the merge queue Jan 23, 2025
Merged via the queue into Mbed-TLS:development with commit 1532ea4 Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg

@tom-cosgrove-arm tom-cosgrove-arm

@gilles-peskine-arm gilles-peskine-arm

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidhorstmann-arm @mpg @tom-cosgrove-arm @yanesca