Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable badges for now #1116

Merged
merged 9 commits into from
Sep 13, 2024
Merged

Disable badges for now #1116

merged 9 commits into from
Sep 13, 2024

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Sep 12, 2024 •
edited
Loading

  • Hide the badges field (it is not implemented and not in scope)
  • Comment out the fields in the PHP form builder as well
  • Add missing header element on the headers that where missing them. So it's constant with the rest of the existing code.

@melroy89 melroy89 added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end labels Sep 12, 2024
@melroy89 melroy89 changed the title Remove headers & disable badges for now Disable badges for now Sep 12, 2024
BentiGorlich
BentiGorlich requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@BentiGorlich BentiGorlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the EntryArticleType:

grafik

Aside from that everything works fine :)

@melroy89 melroy89 added this to the v1.7.2 milestone Sep 12, 2024
@melroy89
Copy link
Member Author

You forgot the EntryArticleType:

grafik

Aside from that everything works fine :)

fixed.

@melroy89 melroy89 merged commit 4d930f6 into main Sep 13, 2024
7 checks passed
@melroy89 melroy89 deleted the remove_badge_field branch September 13, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BentiGorlich BentiGorlich BentiGorlich approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Milestone
v1.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@melroy89 @BentiGorlich