Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit require dep phpseclib/phpseclib. Update minor releases o… #1135

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Sep 19, 2024

  • Add phpseclib/phpseclib package explicitly to composer.json require now, since we depend on it. (it used to be an indirect dependency --> BAD practice)
  • Update minor PHP packages

Fixes:

{"message":"Uncaught PHP Exception Error: \"Class \"phpseclib3\\Crypt\\RSA\" not found\" at KeysGenerator.php line 14","context":{"exception":{"class":"Error","message":"Class \"phpseclib3\\Crypt\\RSA\" not found","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPub/KeysGenerator.php:14"}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-19T16:44:29.966453+02:00","extra":{}}

This was caused by PR: #1101 (comment) (which only removed activitypub package, but also removed this package). However we did needed this phpseclib3 package as well, but.. it was never explicit stated as a require dependency in composer. Hence it was auto-deleted.

@melroy89 melroy89 added bug Something isn't working dependencies Pull requests that update a dependency file labels Sep 19, 2024
@melroy89 melroy89 added the high priority critical issue or PR that impacts production label Sep 19, 2024
@melroy89 melroy89 enabled auto-merge (squash) September 19, 2024 15:12
@melroy89 melroy89 merged commit 9268b2a into main Sep 19, 2024
7 checks passed
@melroy89 melroy89 deleted the add_missing_phpseclib_back branch September 19, 2024 15:40
@melroy89 melroy89 added this to the v1.7.2 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file high priority critical issue or PR that impacts production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants