Rename remaining article to thread #1138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melroy89
added
enhancement
BentiGorlich
requested changes
Sep 20, 2024
|
Ok I will look at it closer tomorrow. Code wise it looks good now |
This pr is less urgent than the 1.7.x fixes. No worries here. It's not really a bug fix. |
BentiGorlich
force-pushed
the
dev/new_features
branch
from
d07c5c3
to
fa6f302
Compare
Co-authored-by: Melroy van den Berg <[email protected]>
BentiGorlich
force-pushed
the
dev/new_features
branch
from
fa6f302
to
09a90b4
Compare
|
Rebased |
BentiGorlich
force-pushed
the
dev/new_features
branch
from
cf72318
to
7cd555b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename all the remaining keywords from
article(s)tothread(s). Making the code more consistent.Which also means I renamed the new valid link for creating a new thread:
new/threadin the URL (same for the API).This PR also finally solves the translation strings that then where still have the key
article,articles,edit_article(which was always missing btw),add_new_article, etc. To the new keys:type.thread,thread,threads,add_new_threadand finallyedit_thread.To be backwards compatible with existing data in the database (specifically the
typecolumn in theentrytable), we keep thearticlestring in theresolveType()function, so t he old string "article" or "articles" are still valid. Same for some Twig templates, we extend with anotherorfor backwards compatibly for now.The next logical follow-up would be to rename
entryas well later.