Hide tab-panels if project is on whitelist #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, it would be great to have it in the official release! |
jhansche
suggested changes
Dec 4, 2018
| @@ -94,6 +96,9 @@ public ShowPanelReply showPanel(ShowPanelRequest arg0) { | |||
| isShowing = false; | |||
| } | |||
|
|
|||
| if (configuration.getUseGerritProjectWhitelist() && ! isGerritProject(arg0.issue())) | |||
| isShowing = false; | |||
There was a problem hiding this comment.
Please follow surrounding code styles: braces around multi-line if blocks, and no space after !
if (configuration.getUseGerritProjectWhitelist() && !isGerritProject(arg0.issue())) {
isShowing = false;
}| @@ -66,6 +68,9 @@ public ShowPanelReply showPanel(ShowPanelRequest request) { | |||
| if (isConfigurationReady()) { | |||
| Collection<Issue> subtasks = request.issue().getSubTaskObjects(); | |||
| show = subtasks != null && subtasks.size() > 0; | |||
|
|
|||
| if (configuration.getUseGerritProjectWhitelist() && ! isGerritProject(request.issue())) | |||
| @@ -81,4 +86,12 @@ private boolean isConfigurationReady() { | |||
| return configuration != null && configuration.getSshHostname() != null && configuration.getSshUsername() != null | |||
| && configuration.getSshPrivateKey() != null && configuration.getSshPrivateKey().exists(); | |||
| } | |||
|
|
|||
| private boolean isGerritProject(final Issue issue) { | |||
| if (issue.getProjectId() == null) | |||
| @@ -166,4 +171,12 @@ private void setUsersForChangeApprovals(GerritChange change) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private boolean isGerritProject(final Issue issue) { | |||
| if (issue.getProjectId() == null) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58