Small polish and performance improvements #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apetres
reviewed
Jan 16, 2019
| @@ -81,4 +86,12 @@ private boolean isConfigurationReady() { | |||
| return configuration != null && configuration.getSshHostname() != null && configuration.getSshUsername() != null | |||
| && configuration.getSshPrivateKey() != null && configuration.getSshPrivateKey().exists(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Seems like duplicated code. What about adding configuration as argument and making the method static?
Another option is to add it as a default method to GerritConfiguration.
There was a problem hiding this comment.
Thanks for found it. I hope, the better review interface and set it as static method.
Now as workaround I have migrated into imp class, and define method in interface.
Yes, it is old way, but it does not duplicate of code :)
… BTW, better realise into interface as Java 8
…eded better use the second version
Change-Id: Ic71f13a07ba7f43272a3001783e510b3a2eba3ba
|
Hi @jhansche , Cheers, |
gonchik
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR includes small adapt for Java 8.
Internally, we reused this #59 PR which fixed issue #58 .
I will be happy if you upload on marketplace.atlassian.com.
Because our administrators can updated through UPM. :)
Thanks
Cheers,
Gonchik Tsymzhitov