Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(originally in #6028)
This optimization will reduce the necessary code in every plugin significantly, can solve the disposing on one place in initializing on one place. Potential bugs will be solved for all of the plugins at one place.
Trendline
plugin is different - I added comments inside theChartTrendline.razor.cs
To answer the questions from previous pr:
I think it is just missing the same disposal logic as the other plugins, it's about the
await JSModule.SafeDisposeAsync();
that is missing.Part of the "refresh" strategy is done in
Refresh
method, but the parametersVertical
andOptions
wont't get there. They are used only in plugin initialization. Thus I think, theOnParameterSet
should have its implementation. But maybe I am missing something.