Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs from adding Youtube widget #306

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Conversation

mechakin
Copy link
Contributor

@mechakin mechakin commented Nov 3, 2023

There were some syntax bugs that came from resolving conflicts, should be fixed now

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astrostation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 9:09pm

@Melkeydev
Copy link
Owner

A few comments:

  • When a person adds the widget through the widget menu - it is automatically toggled to be on. If we add it, can we it toggled off?
  • image
    when a user adds the YT widget on the side bar, it doesnt get appended to the end.

image
I am adding a youtube URL and i pressed enter and I am getting this error
This is because i am using the shorter URL link. When I put the full link it works correctly. Not a blocker.

@mechakin
Copy link
Contributor Author

mechakin commented Nov 3, 2023

To answer your comments

  • We can make the widget toggle off by default
  • Do you want the YT widget to be appended at the end of all the icons?

As for the last comment that is really weird i've tested out this video and a couple others with the shortened link and it seemed to work just fine, there might be a weird bug in the regex to validate the link

Screenshot 2023-11-03 at 5 17 27 PM

@mechakin
Copy link
Contributor Author

mechakin commented Nov 7, 2023

Took your feedback and made sure to fix the issues you addressed, however I wasn't able to replicate the issue where if the person adds the widget through the widget menu, the widget would automatically would be turned on.

That being said:

  • The bug with the shortened video link was because of a small issue with the regex where it would cut off the first letter of the URL if it started with a "v". Should all be fixed now.

  • The YT widget on the sidebar is now appended at the end.

Copy link
Owner

@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Melkeydev Melkeydev merged commit 7c6e0f7 into Melkeydev:staging Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants