Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing comments in API #1066

Merged
merged 1 commit into from
Sep 17, 2024
Merged

doc: add missing comments in API #1066

merged 1 commit into from
Sep 17, 2024

Conversation

rollandf
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10811221210

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 65.298%
Files with Coverage Reduction New Missed Lines %
controllers/nicclusterpolicy_controller.go 1 79.08%
controllers/macvlannetwork_controller.go 2 86.25%
Totals Coverage Status
Change from base Build 10777104492: 0.3%
Covered Lines: 3323
Relevant Lines: 5089
💛 - Coveralls

@rollandf rollandf mentioned this pull request Sep 11, 2024
Merged
@rollandf
Copy link
Member Author

/retest-image_scan

e0ne
e0ne approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e0ne e0ne merged commit 5376ff3 into Mellanox:v24.7.x Sep 17, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@e0ne e0ne e0ne approved these changes

@souleb souleb Awaiting requested review from souleb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rollandf @coveralls @e0ne @adrianchiris