fix: Validate the linkType correctly when it can and cannot be changed #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0ne
reviewed
Oct 1, 2024
almaslennikov
force-pushed
the
link-type-validation-fix
branch
from
78607a9
to
84ceef9
Compare
Pull Request Test Coverage Report for Build 11125131146Details
💛 - Coveralls |
e0ne
approved these changes
Oct 1, 2024
If LINK_TYPE_P1 parameter is not present in the mstconfig defaults, we can't change the link type on the device and should return an error if the actual link type differs from the template. Otherwise, we should not raise an error. Signed-off-by: amaslennikov <[email protected]>
almaslennikov
force-pushed
the
link-type-validation-fix
branch
from
84ceef9
to
82e0934
Compare
ykulazhenkov
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If LINK_TYPE_P1 parameter is not present in the mstconfig defaults, we can't change the link type on the device and should return an error if the actual link type differs from the template. Otherwise, we should not raise an error.