feat: add input validation for external functions#116
Merged
ahmadogo merged 2 commits intoMentoNest:mainfrom Mar 29, 2026
Merged
feat: add input validation for external functions#116ahmadogo merged 2 commits intoMentoNest:mainfrom
ahmadogo merged 2 commits intoMentoNest:mainfrom
Conversation
- Add MAX_SESSION_ID_LEN, MAX_NOTE_LEN, MAX_AMOUNT constants - Add Error variants: InvalidAddress, InvalidSessionId, InvalidNote, AmountTooLarge - Add validate_session_id, validate_amount, validate_note, validate_different_addresses helpers - Apply validation in lock_funds and resolve_dispute - Add 6 unit tests covering zero/negative/oversized amounts, same-address, empty/long session IDs
|
@Mkalbani Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ahmadogo
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #106