Skip to content
This repository has been archived by the owner on Nov 13, 2022. It is now read-only.

Added spotify links to track object #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added spotify links to track object #106

wants to merge 3 commits into from

Conversation

exiify
Copy link

@exiify exiify commented Apr 10, 2021

No description provided.

@Solaris9
Copy link
Contributor

It's hard to read what was changed with all the formatting but it seems like you changed the generic function that searches for songs, it isn't specific to Spotify and every other audio plugin would need to do the same, but there may be talk about changing how this works to another way more suited for it, such as a function the plugin needs to modify the data to keep certain properties

@exiify
Copy link
Author

exiify commented Apr 11, 2021

It's hard to read what was changed with all the formatting but it seems like you changed the generic function that searches for songs, it isn't specific to Spotify and every other audio plugin would need to do the same, but there may be talk about changing how this works to another way more suited for it, such as a function the plugin needs to modify the data to keep certain properties

Why don't we change spotifyUri to something like idk uri2 so every plugin can just return that too, and all I really changed was the getClosestTrack and I added the uri to the track as a string or null. The rest were really just formatting.

@anishshobithps anishshobithps added the enhancement New feature or request label Apr 19, 2021
@anishshobithps anishshobithps added this to the v3 milestone Apr 19, 2021
@MenuDocs MenuDocs deleted a comment from Strandxo Sep 18, 2022
@MenuDocs MenuDocs deleted a comment from Strandxo Sep 18, 2022
@MenuDocs MenuDocs deleted a comment from Strandxo Sep 18, 2022
@MenuDocs MenuDocs deleted a comment from Strandxo Sep 18, 2022
@MenuDocs MenuDocs deleted a comment from Strandxo Sep 18, 2022
@MenuDocs MenuDocs deleted a comment from Strandxo Sep 18, 2022
@MenuDocs MenuDocs deleted a comment from Strandxo Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants