This repository has been archived by the owner on Nov 13, 2022. It is now read-only.
v3: fix create generics #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 18, 2021 00:25
| * Creates a new player manager with the supplied options. | ||
| * | ||
| * @param options The options to supply the player manager. | ||
| * @param klass The provider class to instantiate. |
There was a problem hiding this comment.
I would suggest target is better word here than klass
| * @param options The options to supply the player manager. | ||
| * @param klass The provider class to instantiate. | ||
| */ | ||
| export function create<M extends Manager<any, any>>(options: ExtractOptions<M>, klass?: Class<M>): M |
There was a problem hiding this comment.
same as above klass => target
| */ | ||
| export function create<M extends Manager<any, any>>(options: ExtractOptions<M>, klass?: Class<M>): M | ||
|
|
||
| export function create<M extends Manager<any, any>>(options?: ExtractOptions<M>, klass?: Class<M>): M { |
There was a problem hiding this comment.
same as above klass => target
anishshobithps
added
documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.