This repository has been archived by the owner on Nov 13, 2022. It is now read-only.
Improve handling of voice packets #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works fine in tests 👌🏼 |
|
Looks line this also fixes #136, though after inspection, looking at current manager.ts line 474 and line 475 after PR I think can be removed as it does not do anything useful anyway. |
|
Since this seems to fix some issues and no one else cares to review I'll merge 👌🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr hopes to improve the handling of voice state & server updates by removing the need for the dispatch event name and instead going off the properties is provided.