[DUX-3058]: implement support for App Home tab #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9999years
reviewed
Feb 25, 2025
src/Web/Slack/AesonUtils.hs
Outdated
|
|
||
| -- | 'snakeCaseOptions' that eats trailing underscores. This is so that you can | ||
| -- have a field called "type_". | ||
| snakeCaseOptionsEatTrailing :: Options |
Member
There was a problem hiding this comment.
The name is really long, but maybe it should be longer? snakeCaseOptionsEatTrailingUnderscores
9999years
reviewed
Feb 25, 2025
9999years
approved these changes
Feb 25, 2025
Member
9999years
left a comment
9999years
left a comment
There was a problem hiding this comment.
Left a couple non-blocking nits
lf-
force-pushed
the
jade/dux-3058-home-tab
branch
4 times, most recently
from
e2fb8af to
f4caf93
Compare
These events are sent when app home is enabled.
This is useful for if downstream users have to add new block types, or if we are decoding arbitrary input from Slack.
This also implements the bits necessary to add more of the views endpoints in the future, json-wise.
We will have some breaking changes in my stack later, so major it is.
lf-
force-pushed
the
jade/dux-3058-home-tab
branch
from
f4caf93 to
1f0ade9
Compare
9999years
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that Slacklinker can use it (and maybe we can also rip out some related code in the Mercury backend).
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
(unreleased)on the Changelog