DUX-3346: Support custom deserializers in request verification #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns out to be necessary for the impressively messed up nonsense that Slack does with their interactive webhooks, which range from "json in a form parameter" (WHAT) to "entirely putting the thing in form parameters". More code to support this may come in the future, but we need this foundation to be able to disentangle the bad code in mwb using this.
9999years
reviewed
Apr 18, 2025
Comment on lines
+123
to
+124
| validateRequestRaw decoder secret sig reqTs body = | ||
| liftIO getPOSIXTime >>= \time -> pure $ validateRequestRaw' decoder time secret sig reqTs body |
Member
There was a problem hiding this comment.
Suggested change
| validateRequestRaw decoder secret sig reqTs body = | |
| liftIO getPOSIXTime >>= \time -> pure $ validateRequestRaw' decoder time secret sig reqTs body | |
| validateRequestRaw decoder secret sig reqTs body = do | |
| time <- liftIO getPOSIXTime | |
| pure $ validateRequestRaw' decoder time secret sig reqTs body |
Use do notation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to be necessary for the impressively messed up nonsense that Slack does with their interactive webhooks, which range from "json in a form parameter" (WHAT) to "entirely putting the thing in form parameters".
More code to support this may come in the future, but we need this foundation to be able to disentangle the bad code in mwb using this.
Sadly does a breaking change due to
import Web.Slack.Experimental.RequestVerification (SlackVerificationFailed(..))no longer importing constructors. The rest of this is not breaking changes.Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
(unreleased)on the Changelog