Skip to content

Conversation

@ldub
Copy link
Contributor

@ldub ldub commented Sep 16, 2025

added shared/unshared events

@ldub ldub force-pushed the lev/channel-shared-events branch from 04dfab4 to a1a132e Compare September 16, 2025 06:03
@ldub ldub requested a review from Copilot September 16, 2025 06:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Slack channel shared and unshared webhook events to the Haskell Slack API library. The implementation includes parsing JSON webhook payloads for these events and converting them to appropriate Haskell data types.

  • Added data types ChannelSharedEvent and ChannelUnsharedEvent with appropriate fields
  • Implemented JSON parsing for both event types in the Event sum type
  • Added comprehensive test coverage with golden test files

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Web/Slack/Experimental/Events/Types.hs Added new data types and JSON parsing for channel shared/unshared events
tests/Web/Slack/Experimental/Events/TypesSpec.hs Added test cases for the new event types
tests/golden/SlackWebhookEvent/channel_shared.json Test data for channel shared event
tests/golden/SlackWebhookEvent/channel_shared.golden Expected parsing output for channel shared event
tests/golden/SlackWebhookEvent/channel_unshared.json Test data for channel unshared event
tests/golden/SlackWebhookEvent/channel_unshared.golden Expected parsing output for channel unshared event

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ldub ldub force-pushed the lev/channel-shared-events branch from a1a132e to e795596 Compare September 16, 2025 06:04
@ldub ldub requested a review from rjmholt September 16, 2025 06:07
@ldub ldub merged commit aa17b7d into MercuryTechnologies:master Nov 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants