fix for missing previous_names in conversation
#154
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, Slack Web API does not return
previous_namesfor conversation, and requests fail with this kind of error:This PR goes for minimal diff, but the change is breaking. Another, proper way to fix this would be, in this case, to interpret missing
previous_namesinto empty list, but this would require writing custom JSON parser for Conversation. Tell me what you think.After submitting your PR:
(unreleased)on the Changelog