Move all database, stripe, and merit operations into their own respective services folder - #464
Merged
Conversation
|
This PR was not deployed automatically as @jasonhedman does not have access to the Railway project. In order to get automatic PR deploys, please add @jasonhedman to your team on Railway. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jasonhedman
commented
Sep 22, 2025
Contributor
Author
There was a problem hiding this comment.
Ignore lint for seeder scripts. Don't really care about cleanliness here. Same goes for the next few files
jasonhedman
commented
Sep 22, 2025
Contributor
Author
There was a problem hiding this comment.
use types from TRPC
jasonhedman
commented
Sep 22, 2025
Contributor
|
can you just bump the TS sdk at the same time here? |
rsproule
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final code cleanliness refactor. Isolates all external services into their own separate folders.
@/services/db- all database reads and writes. Imporingdboutside of this folder will cause a lint error@/services/stripe- all stripe operations (create link + webhook). Removedpayment_intent.suceededhandler because the current one always errors and if it didnt error we would double credit. Since all payments happen thru checkouts we can rely strictly on the checkout success event.@/services/merit- all usage of the Terminal SDKWill drop comments in the file viewer for notable changes.