fix: updated token endpoint auth method to make it work with auth.js - #642
Conversation
|
@sachigoyal is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
|
Let's move the repo here into We need to rename it in package.json to |
There was a problem hiding this comment.
Additional Comments:
packages/sdk/auth-js-provider/src/index.ts (line 49):
The import path in the JSDoc documentation comment references the old package name @merit/echo-authjs-provider instead of the new name @merit-systems/echo-authjs-provider, which will mislead developers.
View Details
📝 Patch Details
diff --git a/packages/sdk/auth-js-provider/src/index.ts b/packages/sdk/auth-js-provider/src/index.ts
index 5622dcb4..c700bbaa 100644
--- a/packages/sdk/auth-js-provider/src/index.ts
+++ b/packages/sdk/auth-js-provider/src/index.ts
@@ -46,7 +46,7 @@ function validateAppId(appId: string, context?: string): void {
* #### Configuration
*```ts
* import { Auth } from "@auth/core"
- * import Echo from "@merit/echo-authjs-provider"
+ * import Echo from "@merit-systems/echo-authjs-provider"
*
* const request = new Request(origin)
* const response = await Auth(request, {
Analysis
JSDoc import example references incorrect package name
What fails: JSDoc comment in packages/sdk/auth-js-provider/src/index.ts shows import from @merit/echo-authjs-provider but package.json declares name as @merit-systems/echo-authjs-provider
How to reproduce:
- Check JSDoc at line 49: shows
import Echo from "@merit/echo-authjs-provider" - Check package.json at line 2: shows
"name": "@merit-systems/echo-authjs-provider" - Verify templates/authjs/src/auth/index.ts correctly imports from
@merit-systems/echo-authjs-provider
Result: Documentation shows wrong import path, misleading developers to import from non-existent old package name
Expected: JSDoc should show correct import path matching the actual package name in package.json to ensure developers use the right import statement
cb0a551 to
b9f6c41
Compare
|
@rsproule updated the ci/cd pipelines, added the template and updated docs |
rsproule
left a comment
There was a problem hiding this comment.
Just remove the one bit from the echo app. Otherwise LGTM.
|
@rsproule let me know if there are any changes needed. otherwise feel free to merge it |
Fixed the echo provider package that was broken when paired with auth.js
here's a demo app using it: https://echo-provider-authjs.vercel.app
open sourced: https://github.com/sachigoyal/echo-provider-authjs
as the npm package isnt published yet, adding a template / docs might be misleading to end customer
we should first test this package, publish in npm, and then we can write documentation
tackles issue #598
@rsproule @fmhall can you take a look?