Skip to content

ref: API key and transaction count queries #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsproule merged 1 commit into from
Nov 12, 2025
Merged

ref: API key and transaction count queries #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...ages/app/control/src/app/(app)/app/[id]/(overview)/_components/setup/connection/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ export const Connection: React.FC<Props> = ({ appId }) => {
refetchInterval: shouldRefetch ? 2500 : undefined,
}
);
const [numApiKeys] = api.user.apiKeys.count.useSuspenseQuery({ appId });
const [numApiKeys] = api.user.apiKeys.count.useSuspenseQuery(
{ appId },
{
refetchInterval: shouldRefetch ? 2500 : undefined,
}
);

const isConnected = useMemo(() => {
return numTokens > 0 || numApiKeys > 0;
Expand Down
12 changes: 2 additions & 10 deletions packages/app/control/src/app/(app)/app/[id]/_hooks/use-app-setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,10 @@ export const useAppConnectionSetup = (appId: string) => {
refetchInterval: shouldRefetchConnection ? 2500 : undefined,
}
);
const [transactionsCount] = api.apps.app.transactions.count.useSuspenseQuery(
{
appId,
},
{
refetchInterval: shouldRefetchTransactions ? 2500 : undefined,
}
Comment on lines -28 to -34

@rsproule rsproule Nov 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing transaction count here?

@dhvll dhvll Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Lines 45-52) and (Lines 28-34). Both queries were fetching the exact same data from the exact same endpoint!
Both queries would make separate API calls every 2.5 seconds.

The core bug: isConnected should only check if the connection is set up (OAuth tokens OR API keys exist), NOT whether transactions have been made.

If a user made transactions but deleted their API key, isConnected would still be true (wrong!)
The logic mixed two separate concepts: connection setup vs. usage
Different polling strategies for the same data caused race conditions

So kept second query.

);

const isConnected = useMemo(() => {
return numTokens > 0 || numApiKeys > 0 || transactionsCount > 0;
}, [numTokens, numApiKeys, transactionsCount]);
return numTokens > 0 || numApiKeys > 0;
}, [numTokens, numApiKeys]);

useEffect(() => {
setShouldRefetchConnection(!isConnected);
Expand Down
Loading