-
Notifications
You must be signed in to change notification settings - Fork 89
[Release] cli template + api key mode dash + user fallback #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
89929d8
ref: API key and transaction count queries
dhvll 5b7d31f
feat: echo cli template
sachigoyal 5ac5f6a
fix
sachigoyal c498d33
fix
sachigoyal 0c50e7f
refactored constants
sachigoyal 17330f6
feat: added clear-history, and render prev messages on resume
sachigoyal 0a4388d
feat: local wallet
sachigoyal 30794f9
Merge pull request #675 from sachigoyal/sachi/echo-cli-template
zdql 463a4b7
keep .env.local + rm pnpm artifacts
rsproule 3c9a8ac
Merge pull request #678 from Merit-Systems/rfs/fix-cli-tempalte
rsproule e04e301
Merge pull request #656 from dhvll/bug-app-creationFlow
rsproule 1958846
fix user display
zdql 839fccb
id instead of email snippet
zdql ed7d93d
Merge pull request #679 from Merit-Systems/br/fix-user-display
rsproule File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ECHO_APP_ID="74d9c979-e036-4e43-904f-32d214b361fc" | ||
| NEXT_PUBLIC_ECHO_APP_ID="74d9c979-e036-4e43-904f-32d214b361fc" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| node_modules | ||
| dist | ||
| .env* | ||
| !.env.local | ||
| .pnpm-store |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a transaction has no name but has an email, the code tries to display the user's ID. However, the ID can be null according to the type definition, which will display the string "null" to users instead of a proper fallback.
View Details
📝 Patch Details
Analysis
Null user.id displays "null" string in transaction and user lists
What fails: TransactionRow component in transactions.tsx (line 116) and UserRow component in users.tsx (line 191) display the literal string "null" when user.id is null but user.email exists
How to reproduce:
Result: Users see "null made 5 requests" instead of a proper fallback like "x402 Users made 5 requests"
Expected: Should show meaningful fallback text per database schema (Transaction.userId is nullable String?) and backend service pattern (sets name to 'x402 Users' when userId is null)