Skip to content

[codex] Fix mobile navbar search overlap#56

Merged
nytera merged 2 commits intomainfrom
codex/fix-mobile-search-toggle-overlap
Mar 31, 2026
Merged

[codex] Fix mobile navbar search overlap#56
nytera merged 2 commits intomainfrom
codex/fix-mobile-search-toggle-overlap

Conversation

@nytera
Copy link
Copy Markdown
Member

@nytera nytera commented Mar 31, 2026

What changed

  • keep the mobile navbar search container in the flex flow on production builds
  • reserve stable width for the theme toggle so it stays clickable on narrow screens
  • extend the browser regression test to assert that mobile search does not overlap the theme toggle at 320px

Why

The generated navbar search container could end up position: absolute in the production CSS order, which let the search trigger sit on top of the color mode toggle on mobile.

Impact

  • mobile navbar search and theme toggle no longer visually overlap
  • the regression is now covered in Playwright against the built site

Validation

  • npm test -- src/theme/SearchBar/index.test.tsx
  • npm run build
  • npx playwright test e2e/navbar-search.spec.ts

@nytera nytera marked this pull request as ready for review March 31, 2026 11:38
@nytera nytera requested a review from ntaslab as a code owner March 31, 2026 11:38
@nytera nytera merged commit b788af5 into main Mar 31, 2026
3 checks passed
@nytera nytera deleted the codex/fix-mobile-search-toggle-overlap branch March 31, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant