Use CMake to perform installation, and RPM macros #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! I haven't looked at the manual changes you sent yet; I suppose the bit you mention above in your comment has been worked in with your edits. |
Hi Ben, It hasn't, actually. I sent my edits to you already, before I thought of it. I will make the change now and re-send the edition, since that will probably be the easiest for both of us (it's easier for me than explaining where to make the edition, and easier for you too, I hope). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ben,
This PR updates the RPM spec file for the 4.1 release, adopts recommended RPM macros rather than hard-coding things (though that did appear robust in the past), and makes CMake capable of installing SLiMgui, slim, and eidos with desktop integration (which simplifies the role of RPM and makes the spec file more maintainable).
It didn't cross my mind until now, but the following should work beautifully and provide desktop integration on Linux platforms when building from source and should also be integrated into the manual's installation instructions:
cmake -D BUILD_SLIMGUI=ON make make install # This line, on Linux, will now *also* install Desktop integration files.