Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLiM.spec to work with Qt 6 for Fedora and openSUSE #469

Merged
merged 28 commits into from
Sep 17, 2024

Commits on Sep 2, 2024

  1. Update SLiM.spec

    bryce-carson authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9464bfe View commit details
    Browse the repository at this point in the history
  2. Update SLiM.spec

    bryce-carson authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6bcef40 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Add files via upload

    bryce-carson authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5d32b93 View commit details
    Browse the repository at this point in the history
  2. Update SLiM.spec

    bryce-carson authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ebc1ab2 View commit details
    Browse the repository at this point in the history
  3. Update SLiM.spec

    Try to protect RHEL 8 from whatever was happening in its build system to break stuff.
    bryce-carson authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    bc86920 View commit details
    Browse the repository at this point in the history
  4. Update SLiM.spec

    bryce-carson authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3d0ef71 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3814e97 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    53782ea View commit details
    Browse the repository at this point in the history
  2. Specify source and build directory manually on RHEL 8

    RHEL 8 does not, apparently, specify source and build directories when it calls `cmake` (not `cmake --build`, that's a different step). This causes CMake to set the source and build directories to both be the current directory; apparently this causes the macros `%_vpath_srcdir` and `%_vpath_builddir` to be ignored during `cmake --build`, which may be the ultimate cause of the issues we've encountered recently with the CMake build system on RHEL 8 builders.
    
    We'll see how this commit affects the RHEL 8 builders. It shouldn't affect the others, because when the builder is not RHEL 8 the macro `%sourceAndBuilddir` should expand to an empty string.
    bryce-carson authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    608268c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bac7b81 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4444fa0 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    865299c View commit details
    Browse the repository at this point in the history
  2. Substitute the build directory in the expanded macro %cmake_build

    This may or may not work. RPM syntax is a little confusing (beyond the basics).
    bryce-carson authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    e21686a View commit details
    Browse the repository at this point in the history
  3. Conditionally create and change to the build directory

    While connected to a COPR VM and chrooted into an EPEL 8 environment, it appears that the EPEL 8 build environment has a CMake which:
    1. Isn't directed to create an out of source build, for whatever reason (I had troubles determining exactly what was going on)
    2. Assumes that the current directory is both the source and build directory (the current directory being the source directory which is changed to by rpmbuild automatically, I think).
    
    As far as I can tell, the easiest way around issue MesserLab#440 to enable MesserLab#465 and MesserLab#468 is to make the build directory and change to it before calling cmake --build, but this only works if we manually specify the source and build directory when calling `%cmake`, which shouldn't be too delicate, as long as the definition of `%cmake` doesn't include source and build directories on other distributions.
    
    I'm out of practice with rpmbuild and COPR's finer details, or I never was practiced in using these at this level, and I don't know a better way of debugging the build process at this point after investigating through SSH than to just submit a new build. I got stuck trying to create a new SRPM with the edited spec file. It's easier to just edit on GitHub like this and have an automatic build tell me if things are going to work as I expect this might. If it doesn't then I'm calling in reinforcements to investigate the issue for me and offer their support (the Fedora community!).
    bryce-carson authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    9124094 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    75fbd15 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    f6956ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c5796c6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fbd91ca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    71174df View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0a06cf7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c58217b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7434e19 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Configuration menu
    Copy the full SHA
    e935898 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7520e9 View commit details
    Browse the repository at this point in the history
  3. Push SLiM.spec

    bryce-carson authored Sep 15, 2024
    Configuration menu
    Copy the full SHA
    9d404a6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    675f78f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    3116d38 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    f2ec557 View commit details
    Browse the repository at this point in the history