-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SLiM.spec to work with Qt 6 for Fedora and openSUSE #469
Merged
Commits on Sep 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9464bfe - Browse repository at this point
Copy the full SHA 9464bfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bcef40 - Browse repository at this point
Copy the full SHA 6bcef40View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5d32b93 - Browse repository at this point
Copy the full SHA 5d32b93View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebc1ab2 - Browse repository at this point
Copy the full SHA ebc1ab2View commit details -
Try to protect RHEL 8 from whatever was happening in its build system to break stuff.
Configuration menu - View commit details
-
Copy full SHA for bc86920 - Browse repository at this point
Copy the full SHA bc86920View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d0ef71 - Browse repository at this point
Copy the full SHA 3d0ef71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3814e97 - Browse repository at this point
Copy the full SHA 3814e97View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 53782ea - Browse repository at this point
Copy the full SHA 53782eaView commit details -
Specify source and build directory manually on RHEL 8
RHEL 8 does not, apparently, specify source and build directories when it calls `cmake` (not `cmake --build`, that's a different step). This causes CMake to set the source and build directories to both be the current directory; apparently this causes the macros `%_vpath_srcdir` and `%_vpath_builddir` to be ignored during `cmake --build`, which may be the ultimate cause of the issues we've encountered recently with the CMake build system on RHEL 8 builders. We'll see how this commit affects the RHEL 8 builders. It shouldn't affect the others, because when the builder is not RHEL 8 the macro `%sourceAndBuilddir` should expand to an empty string.
Configuration menu - View commit details
-
Copy full SHA for 608268c - Browse repository at this point
Copy the full SHA 608268cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bac7b81 - Browse repository at this point
Copy the full SHA bac7b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4444fa0 - Browse repository at this point
Copy the full SHA 4444fa0View commit details
Commits on Sep 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 865299c - Browse repository at this point
Copy the full SHA 865299cView commit details -
Substitute the build directory in the expanded macro
%cmake_build
This may or may not work. RPM syntax is a little confusing (beyond the basics).
Configuration menu - View commit details
-
Copy full SHA for e21686a - Browse repository at this point
Copy the full SHA e21686aView commit details -
Conditionally create and change to the build directory
While connected to a COPR VM and chrooted into an EPEL 8 environment, it appears that the EPEL 8 build environment has a CMake which: 1. Isn't directed to create an out of source build, for whatever reason (I had troubles determining exactly what was going on) 2. Assumes that the current directory is both the source and build directory (the current directory being the source directory which is changed to by rpmbuild automatically, I think). As far as I can tell, the easiest way around issue MesserLab#440 to enable MesserLab#465 and MesserLab#468 is to make the build directory and change to it before calling cmake --build, but this only works if we manually specify the source and build directory when calling `%cmake`, which shouldn't be too delicate, as long as the definition of `%cmake` doesn't include source and build directories on other distributions. I'm out of practice with rpmbuild and COPR's finer details, or I never was practiced in using these at this level, and I don't know a better way of debugging the build process at this point after investigating through SSH than to just submit a new build. I got stuck trying to create a new SRPM with the edited spec file. It's easier to just edit on GitHub like this and have an automatic build tell me if things are going to work as I expect this might. If it doesn't then I'm calling in reinforcements to investigate the issue for me and offer their support (the Fedora community!).
Configuration menu - View commit details
-
Copy full SHA for 9124094 - Browse repository at this point
Copy the full SHA 9124094View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75fbd15 - Browse repository at this point
Copy the full SHA 75fbd15View commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f6956ab - Browse repository at this point
Copy the full SHA f6956abView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5796c6 - Browse repository at this point
Copy the full SHA c5796c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbd91ca - Browse repository at this point
Copy the full SHA fbd91caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71174df - Browse repository at this point
Copy the full SHA 71174dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a06cf7 - Browse repository at this point
Copy the full SHA 0a06cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c58217b - Browse repository at this point
Copy the full SHA c58217bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7434e19 - Browse repository at this point
Copy the full SHA 7434e19View commit details
Commits on Sep 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e935898 - Browse repository at this point
Copy the full SHA e935898View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7520e9 - Browse repository at this point
Copy the full SHA e7520e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d404a6 - Browse repository at this point
Copy the full SHA 9d404a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 675f78f - Browse repository at this point
Copy the full SHA 675f78fView commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3116d38 - Browse repository at this point
Copy the full SHA 3116d38View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f2ec557 - Browse repository at this point
Copy the full SHA f2ec557View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.