Repository navigation
Rename floodfill to flood_fill, deprecating floodfill. - #143
Jenny Hickson (jennyhickson) merged 9 commits into
Conversation
Theo Geddes (mo-tgeddes)
left a comment
There was a problem hiding this comment.
Hi Jenny, this looks good thanks. Could you please add a 'release notes' page to the documentation and add this as an entry under Deprecations? For example, https://metoffice.github.io/ANTS/release_notes/2.1.html#deprecations
…S into 109-deprecate-floodfill
Theo Geddes (mo-tgeddes)
left a comment
There was a problem hiding this comment.
I can't do a suggested change since the file wasn't changed, but there is a reference to floodfill in https://github.com/MetOffice/ANTS/blob/main/lib/ants/utils/cube.py#L1470 and uses the words floodfilled in https://github.com/MetOffice/ANTS/blob/main/lib/ants/exceptions.py#L26 which might still be the correct wording? Up to you :)
Thanks. I've adjusted all of those. I debated The name of the exception I left be since all the exceptions are spaceless - I guess the equvialent here would be |
Theo Geddes (mo-tgeddes)
left a comment
There was a problem hiding this comment.
Looks good thank you. I'm happy with keeping the exception name as is
edff7e6
into
MetOffice:main
Closes #109
To be completed prior to review request and updated as required during the review process.
If the answer to an item on the list is not applicable, feel free to replace the checkbox with 'N/A' to give extra clarity.
All developers are reminded to follow the ancil working practices
Branch
Related branches (e.g. ancillary-file-science):
jennyhickson/ancillary-file-science:rename_floodfill MetOffice/ancillary-file-science#50
ANTS rose stem logs
ANTS_109/run3
ancillary-file-science rose stem logs
ancil_sci_109/run2
Testing
For core ANTS only tests, the bare minimum that will be accepted is the
group=unittestsbut many, if not most, changes will need to test other groups to ensure they meet reviewer expectations. In general, it should be possible and is advised to run thegroup=allgroup prior to review submission as this will catch any consequential issues. Additionally you must run theancillary-file-sciencetests, pointing at your branch, withgroup=allto capture any behaviour changes affecting Science codes.If your change will alter existing science results, you will need to seek appropriate Scientific validation and confirm that the model has been initialised with your new development. Inspecting a change in xconv/pyplot/visualiser of choice is not sufficient to demonstrate the model can be initialised from your file.
Impact of change
cylc vip ./rose-stem -z group=alltestscylc vip ./rose-stem -z group=alltestsApprovals for this change
New functionality further testing
These tasks must succeed for your ticket to pass review.
Other
Rose stem logs
Please copy in the contents of your trac_status.log file(s) below (found in the cylc-run directory for your rose stem run) to your rose-stem testing here. Note: if your changes lead to a change in answers, you must run
cylc vip ./rose-stem -z group=allto help ensure all affected configurations has been flagged up.Fri 27 Mar 10:54:11 GMT 2026
Git status:
[
"?? ../.idea/"
]
Commit:
c3a2ee3
Test Results - Summary
Test Results - Detail
Fri 27 Mar 11:09:31 GMT 2026
Git status:
[
" M app/install_cold/rose-app.conf",
"?? ../.idea/"
]
Commit:
8c4dba9921bd384f0907c6e75e283f060110c57d
Test Results - Summary
Test Results - Detail