Skip to content

Add a note to the regridding tutorial re TwoStage vs AreaWeighted - #188

Merged
Andrew Clark (arjclark) merged 1 commit into
MetOffice:mainfrom
arjclark:add_note_to_regrid_tutorial
Sep 24, 2026
Merged

Andrew Clark (arjclark) merged 1 commit into
MetOffice:mainfrom
arjclark:add_note_to_regrid_tutorial

Conversation

@arjclark

@arjclark Andrew Clark (arjclark) commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

To be completed prior to review request and updated as required during the review process.

If the answer to an item on the list is not applicable, feel free to replace the checkbox with 'N/A' to give extra clarity.

All developers are reminded to follow the ancil working practices


Impact of change

  • This will maintain results for ANTS cylc vip ./rose-stem -z group=all tests
  • This will this maintain results for ancillary-file-science cylc vip ./rose-stem -z group=all tests
  • If this change adds a new capability, evidence has been supplied to show testing of ancillary generation across different resolutions e.g. For global ancillary generation capabilities for use in NWP n1280e is expected to have been tested
  • This change has significantly impacted required resources (runtime and memory) in existing ancillary generation (if yes, give details)
  • This change alters existing ancils
Add further comments/details for your reviewers here on the impacts of the change......

Approvals for this change

  • I have approval from the ANTS core development team for these changes

New functionality further testing

  • If adding new functionality to existing codes, I confirm that the new code doesn't change results when it is switched off and ''works'' when switched on
  • Unittests have been added
  • Rose stem tests have been added for any new functionality
  • If adding new functionality please confirm that the new code compares across different standard decompositions.
  • I have not encountered any failures in my rose-stem output(s)
    These tasks must succeed for your ticket to pass review.
  • I have remembered to run the code style check tasks/tools
Docs built locally and inspected in firefox.

Other

  • I have read the Contributor Licence Agreement
  • I have added my name and affiliation to the Contributors list if I am not already on there in this PR.
  • The issue labels, milestones, etc. are correct
  • Links to all related issues have been provided in the pull request description
  • I have requested a code reviewer
  • Source data has been added or changed - please include a link to the license
I confirm that all code is my own and that my contributions are not subject to copyright or license restrictions (see Contributor Licence Agreement). Andrew Clark
I confirm I have not knowingly violated intellectual property rights (IPR) and have taken sensible measures to prevent doing so, including appropriate attribution for usage of Generative AI. I confirm that this work is my own, and I understand that it is my responsibility to ensure I am not violating others’ IPR. This includes taking reasonable steps to ensure that all tools used while creating this contribution did not infringe IPR. Andrew Clark

@arjclark Andrew Clark (arjclark) added this to the 4.0 milestone Sep 23, 2026
@arjclark Andrew Clark (arjclark) added 📚 documentation Improvements or additions to documentation ✨ enhancement Feature request for new capability labels Sep 23, 2026

@alasdair-roy alasdair-roy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that!

@arjclark
Andrew Clark (arjclark) merged commit 089c179 into MetOffice:main Sep 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation Improvements or additions to documentation ✨ enhancement Feature request for new capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants