Skip to content

Activation fix #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iboutle wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Activation fix #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e8a778
fix activation
iboutle Aug 6, 2026
080266c
another div0 bugfix
iboutle Aug 7, 2026
d523000
another div0 fix
iboutle Aug 10, 2026
57633e6
Revert "another div0 fix"
iboutle Aug 12, 2026
b950416
Revert "another div0 bugfix"
iboutle Aug 12, 2026
852baa3
contrib file
iboutle Aug 12, 2026
d91abe0
fix style
iboutle Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
| james-bruten-mo | James Bruten | Met Office | 2025-12-09 |
| t00sa | Sam Clarke-Green | Met Office | 2026-03-02 |
| Pierre-siddall| Pierre Siddall | Met Office | 2026-03-11 |
| iboutle | Ian Boutle | Met Office | 2026-08-12 |
9 changes: 3 additions & 6 deletions src/activation.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,11 @@ subroutine activate(dt, cloud_mass, cloud_number, w, rho, dnumber, dmac, T, p,

activated_arg = sum(dnccn_all(:))

dactive = zero_real_wp
dmass_d = zero_real_wp
if (Smax_act > smax_act_min .and. .not. l_warm) then

if (iopt_inuc < 4) then
! For lower-order ice nucleation options, need to initialise
! dactive and dmass_d
dactive = zero_real_wp
dmass_d = zero_real_wp
else
if (iopt_inuc > 3) then
! For higher-order ice nucleation schemes, dactive and dmass_d
! can be based on dustphys
dactive = 0.01*dustphys%N(1)
Expand Down